Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color-adjust with autoprefixer 10.4.6 #36258

Merged
merged 2 commits into from
May 7, 2022
Merged

Conversation

amirhossein-karimi
Copy link
Contributor

@amirhossein-karimi amirhossein-karimi commented May 2, 2022

autoprefix, updated, and having trouble color-adjust.

autoprefixer respository change log
developer.mozilla print-color-adjust description

@amirhossein-karimi amirhossein-karimi requested a review from a team as a code owner May 2, 2022 07:49
@mbrodala
Copy link
Contributor

mbrodala commented May 3, 2022

Fixes #36259

@mdo mdo added this to In progress in v5.2.0 via automation May 5, 2022
v5.2.0 automation moved this from In progress to Reviewer approved May 7, 2022
@mdo mdo merged commit f82b2ba into twbs:main May 7, 2022
v5.2.0 automation moved this from Reviewer approved to Done May 7, 2022
@zlach
Copy link

zlach commented May 12, 2022

This is still broken for me

@mbrodala
Copy link
Contributor

@zlach What does this mean exactly?

@zlach
Copy link

zlach commented May 12, 2022

@zlach What does this mean exactly?

Oh, sorry, I just meant that after doing an npm install bootstrap on my React project (node v16.15.0) I still get a warning on npm start

WARNING in ./node_modules/bootstrap/dist/css/bootstrap.css (./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[2]!./node_modules/source-map-loader/dist/cjs.js!./node_modules/bootstrap/dist/css/bootstrap.css)
Module Warning (from ./node_modules/postcss-loader/dist/cjs.js):
Warning

(2482:3) autoprefixer: Replace color-adjust to print-color-adjust. The color-adjust shorthand is currently deprecated.

webpack compiled with 1 warning

@jrochkind
Copy link

Thanks! Any chance of a backport to Bootstrap 4 as a bugfix?

This is mainly an issue for autoprefixer complaints, but it's very annoying, and I'm not sure if there's a good way for bootstrap 4 users to work around with a local override.

@peterlobster
Copy link

peterlobster commented May 12, 2022

I'm with @zlach. After applying the patch, the error kept coming up...

[vite:css] Replace color-adjust to print-color-adjust. The color-adjust shorthand is currently deprecated.

@mbrodala
Copy link
Contributor

Well, the fix simply wasn't relased yet. 😅

@Aminat-Okunuga
Copy link

This is a serious issue I have been battling with for days now all to no avail. I am trying to consume an API I built with Laravel with react as its frontend but kept getting this warning and my pages are blank.

@lapc18
Copy link

lapc18 commented May 13, 2022

To fix it temporarily:

  1. Remove your "node_modules" folder
  2. Remove your "package-lock.json" file
  3. Add to your "package.json" file: "overrides": { "autoprefixer": "10.4.5" }
  4. Finally, run: npm i --save-exact

Some details:

  • React version: ^18.1.0
  • Bootstrap: ^5.1.3
  • cra-template: npx create-react-app my-app --template typescript
  • Node version: v16.14.2
  • NPM version: 8.6.0
  • env: macOS Monterey v12.3.1 | intel processor

Hope it works for u!

@andrewnleon
Copy link

These steps did the trick for me as well thanks dude
Remove your "package-lock.json" file
Add to your "package.json" file: "overrides": { "autoprefixer": "10.4.5" }
Finally, run: npm i --save-exact

wsanchez added a commit to burningmantech/ranger-ims-web that referenced this pull request Jun 1, 2022
Override autoprefixer due to: twbs/bootstrap#36258
wsanchez added a commit to burningmantech/ranger-ims-web that referenced this pull request Jun 1, 2022
@Magiccamera
Copy link

Add to your "package.json" file: "overrides": { "autoprefixer": "10.4.5" }
Finally, run: npm i --save-exact
npm ERR! Override for autoprefixer@^10.4.7 conflicts with direct dependency
changed to: "overrides": { "autoprefixer": "^10.4.7" }
installs fine, but still get autoprefixer: Replace color-adjust to print-color-adjust. The color-adjust shorthand is currently deprecated.
Somewhat irritated may abandon using react bootstrap altogether, I only wanted it for the Navbar

@zulnam
Copy link

zulnam commented Jun 23, 2022

Hi. Any eta on when 5.2.0 is being released? Workaround doesn't seem to work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet